Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

h26forge 2024-07-06 (new formula) #175923

Merged
merged 2 commits into from
Jul 7, 2024
Merged

h26forge 2024-07-06 (new formula) #175923

merged 2 commits into from
Jul 7, 2024

Conversation

acj
Copy link
Contributor

@acj acj commented Jun 29, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added new formula PR adds a new formula to Homebrew/homebrew-core rust Rust use is a significant feature of the PR or issue labels Jun 29, 2024
chenrui333
chenrui333 reviewed Jun 29, 2024
View reviewed changes
Formula/h/h26forge.rb Outdated Show resolved Hide resolved
chenrui333
chenrui333 reviewed Jun 29, 2024
View reviewed changes
Formula/h/h26forge.rb Outdated Show resolved Hide resolved
@chenrui333 chenrui333 mentioned this pull request Jun 29, 2024
Closed
@chenrui333 chenrui333 added the upstream issue An upstream issue report is needed label Jun 29, 2024
@acj acj force-pushed the h26forge-formula branch 2 times, most recently from fa77f48 to 8973849 Compare July 6, 2024 20:49
wrv
wrv reviewed Jul 6, 2024
View reviewed changes
Formula/h/h26forge.rb Outdated Show resolved Hide resolved
@chenrui333 chenrui333 changed the title h26forge (new formula) h26forge 2024-07-06 (new formula) Jul 7, 2024
@acj @chenrui333
h26forge 2024-07-06 (new formula)
d1afd80 
autobump: add h26forge

Signed-off-by: Rui Chen <[email protected]>
@chenrui333 chenrui333 added ready to merge PR can be merged once CI is green and removed upstream issue An upstream issue report is needed labels Jul 7, 2024
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request autobump labels Jul 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 7, 2024

:shipit: @chenrui333 has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jul 7, 2024
@chenrui333
Copy link
Member

@acj @wrv, thanks for your contributions to Homebrew! 🎉 🥇

@BrewTestBot BrewTestBot added this pull request to the merge queue Jul 7, 2024
Merged via the queue into Homebrew:master with commit 16644b9 Jul 7, 2024
14 checks passed
@acj
Copy link
Contributor Author

acj commented Jul 7, 2024

Thanks, all! And thanks @wrv for both the tool and the excellent paper about it.

@acj acj deleted the h26forge-formula branch July 7, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wrv wrv wrv left review comments

@chenrui333 chenrui333 chenrui333 approved these changes

@github-actions GitHub Actions GitHub Actions approved these changes

Assignees
No one assigned
Labels
autobump automerge-skip `brew pr-automerge` will skip this pull request CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. new formula PR adds a new formula to Homebrew/homebrew-core ready to merge PR can be merged once CI is green rust Rust use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@acj @chenrui333 @wrv @BrewTestBot